Skip to content

Add SSE Connection and streamingFetchAdapter tests#625

Merged
EhabY merged 3 commits into
coder:mainfrom
EhabY:add-sse-connection-tests
Oct 21, 2025
Merged

Add SSE Connection and streamingFetchAdapter tests#625
EhabY merged 3 commits into
coder:mainfrom
EhabY:add-sse-connection-tests

Conversation

@EhabY

@EhabY EhabY commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@buenos-nachos buenos-nachos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to review as much as I could, but I feel like I need a bit more context on what we're trying to assert, and the specific concerns we have for the tests

Happy to pair-program on this next week. I'm located in the EST time zone

Comment thread src/websocket/sseConnection.ts
Comment thread test/unit/api/streamingFetchAdapter.test.ts Outdated
Comment thread test/unit/api/streamingFetchAdapter.test.ts Outdated
Comment thread test/unit/api/streamingFetchAdapter.test.ts
Comment thread test/unit/api/streamingFetchAdapter.test.ts
Comment thread test/unit/websocket/sseConnection.test.ts Outdated
Comment thread test/unit/websocket/sseConnection.test.ts
Comment thread test/unit/websocket/sseConnection.test.ts Outdated
Comment thread test/unit/websocket/sseConnection.test.ts
Comment thread test/unit/websocket/sseConnection.test.ts

@buenos-nachos buenos-nachos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go

@EhabY EhabY merged commit 3c499ba into coder:main Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants