added controller test for trying to rename comment threads to invalid titles

Author: Oaphi

test/controllers/comments/rename_test.rb

@@ -23,7 +23,6 @@ class CommentsControllerTest < ActionController::TestCase
       before_title = comment_threads(name).title
 
       try_rename_thread(comment_threads(name))
-
       @thread = assigns(:comment_thread)
 
       assert_response(:found)
@@ -32,4 +31,18 @@ class CommentsControllerTest < ActionController::TestCase
       assert_equal before_title, @thread.title
     end
   end
+
+  test 'should correctly handle invalid thread titles' do
+    sign_in users(:admin)
+
+    ['', 'a' * 512].each do |title|
+      try_rename_thread(comment_threads(:normal), title: title)
+      @thread = assigns(:comment_thread)
+
+      assert_response(:found)
+      assert_not_nil @thread
+      assert_not @thread.valid?
+      assert_not_nil flash[:danger]
+    end
+  end
 end