Skip to content

Allow ability descriptions to be edited#2031

Merged
ArtOfCode- merged 20 commits into
developfrom
0valt/abilities-edit
Mar 22, 2026
Merged

Allow ability descriptions to be edited#2031
ArtOfCode- merged 20 commits into
developfrom
0valt/abilities-edit

Conversation

@Oaphi
Copy link
Copy Markdown
Member

@Oaphi Oaphi commented Mar 20, 2026

Only ability descriptions are editable for now (the user has to at least be a moderator for the button to show up):

ssr-2026-03-21_03.44.41.mp4

Global mods & admins will also be able to push the changes network-wide:
image

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (de29259) to head (99bb891).
⚠️ Report is 21 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 76.09% <100.00%> (+0.24%) ⬆️
helpers 85.09% <ø> (ø)
jobs 66.88% <ø> (ø)
models 93.04% <100.00%> (+0.02%) ⬆️
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi changed the title Allow global admins to edit abilities Allow ability descriptions to be edited Mar 21, 2026
@Oaphi Oaphi marked this pull request as ready for review March 21, 2026 01:50
@Oaphi Oaphi requested review from a team, ArtOfCode-, cellio and trichoplax March 21, 2026 01:50
Copy link
Copy Markdown
Member

@ArtOfCode- ArtOfCode- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two semi-related requests:

  • I think it's fine to allow moderators to edit these - gives communities some agency and reduces the admin burden. If we're doing that -
  • while we're here anyway, can we add a checkbox for global mods/admins to push the edit to network, which will update matching abilities where the description has not locally diverged? It's fine for that check to just be "body matches previous state" as there's no history for abilities.

Comment thread db/schema.rb
t.index ["community_id"], name: "index_categories_on_community_id"
t.index ["default_filter_id"], name: "index_categories_on_default_filter_id"
t.index ["license_id"], name: "index_categories_on_license_id"
t.index ["min_view_trust_level"], name: "index_categories_on_min_view_trust_level"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, we forgot to update the schema in the recent updates - adding a comment here to avoid confusion

@Oaphi Oaphi requested a review from ArtOfCode- March 21, 2026 22:01
@ArtOfCode- ArtOfCode- merged commit e88f0ab into develop Mar 22, 2026
13 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/abilities-edit branch March 22, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants