Repo hardening: fix install instructions, dead imports, hygiene#2
Open
cognis-digital wants to merge 3 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#2cognis-digital wants to merge 3 commits into
cognis-digital wants to merge 3 commits into
Conversation
f4615ff to
791eddb
Compare
…rehensive cross-platform install scripts - README opens with a plain-language "What is this?" overview - comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source) - verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
5b3ec23 to
16ae293
Compare
added 2 commits
June 13, 2026 09:17
- core.py: replace bare except with StigsentryError; validate target exists before scanning; guard CSV column presence; handle empty files and rows with missing stig_id; guard emit_poam file write - cognis_mil/cli.py: wrap scan_fn call to catch all exceptions and print a clean stderr message + exit 2 (no raw tracebacks) - cognis_mil/cli.py: fix bare open() file write with context manager - cognis_mil/audit.py: fix unbound variable `i` when log is empty; use specific json.JSONDecodeError instead of bare except - cognis_mil/models.py: fix E702 semicolons in finalize() - cognis_mil/classmark.py: fix E701 inline if statements - cognis_mil/exporters.py: fix E702, F541, E501 throughout - cognis_mil/__init__.py: use explicit re-export syntax for F401 clean - tests/test_hardening.py: 13 new tests for error/edge paths (missing file, malformed JSON, non-list JSON, empty file, empty array, CSV missing columns, nonexistent target, empty directory, all-pass input, malformed JSON during scan, missing stig_id, empty POAM, CLI exit-code 2 on bad target)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.