Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#2

Open
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#2
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 1 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 15 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from f4615ff to 791eddb Compare June 12, 2026 22:04
…rehensive cross-platform install scripts

- README opens with a plain-language "What is this?" overview
- comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source)
- verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from 5b3ec23 to 16ae293 Compare June 13, 2026 12:43
Cognis Digital added 2 commits June 13, 2026 09:17
- core.py: replace bare except with StigsentryError; validate target
  exists before scanning; guard CSV column presence; handle empty files
  and rows with missing stig_id; guard emit_poam file write
- cognis_mil/cli.py: wrap scan_fn call to catch all exceptions and
  print a clean stderr message + exit 2 (no raw tracebacks)
- cognis_mil/cli.py: fix bare open() file write with context manager
- cognis_mil/audit.py: fix unbound variable `i` when log is empty;
  use specific json.JSONDecodeError instead of bare except
- cognis_mil/models.py: fix E702 semicolons in finalize()
- cognis_mil/classmark.py: fix E701 inline if statements
- cognis_mil/exporters.py: fix E702, F541, E501 throughout
- cognis_mil/__init__.py: use explicit re-export syntax for F401 clean
- tests/test_hardening.py: 13 new tests for error/edge paths
  (missing file, malformed JSON, non-list JSON, empty file, empty array,
   CSV missing columns, nonexistent target, empty directory, all-pass
   input, malformed JSON during scan, missing stig_id, empty POAM,
   CLI exit-code 2 on bad target)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant