Conversation
austyhooong
reviewed
May 22, 2026
| } | ||
|
|
||
| private: | ||
| int rob_linear(std::span<int>& nums) { |
There was a problem hiding this comment.
spanは元々lightweight viewなので&は必要ないかと思います
nodchip
reviewed
May 22, 2026
| return max(nums[0], nums[1]); | ||
| } | ||
|
|
||
| vector<int>maxRobbedMoneyWithFirstRobbed(nums.size(), 0); |
| } | ||
| int robbed_2_previous_max_money = nums[0]; | ||
| int robbed_previous_max_money = nums[1]; | ||
| for(int i = 2; i < nums.size(); ++i) { |
There was a problem hiding this comment.
if for のあとにスペースが空いているものと空いていないものとが混ざっているのが気になりました。空けるほうに統一するとよいと思います。
参考までにスタイルガイドへのリンクを共有いたします。
https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace
if (b) { // Space after the keyword in conditions and loops.
なお、このスタイルガイドは“唯一の正解”というわけではなく、数あるガイドラインの一つに過ぎません。チームによって重視される書き方や慣習も異なります。そのため、ご自身の中に基準を持ちつつも、最終的にはチームの一般的な書き方に合わせることをお勧めします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/house-robber-ii/