fix: use false/true instead of 0/1 for bool assignments (MISRA 10.3)#2407
Open
theherrovn-sys wants to merge 1 commit into
Open
fix: use false/true instead of 0/1 for bool assignments (MISRA 10.3)#2407theherrovn-sys wants to merge 1 commit into
theherrovn-sys wants to merge 1 commit into
Conversation
- Replace bool ret = 0 with bool ret = false in can_common.h - Replace ret = 1 with ret = true in can_common.h - Add MISRA 10.3 suppression for opendbc toyota.h (pending opendbc PR #3256) This enables catching int-as-bool in MISRA rule 10.3, fixing commaai#2105.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces MISRA rule 10.3 for bool assignments by catching integer literals 0/1 used where false/true are expected. Fixes #2105.
Changes
panda
bool ret = 0withbool ret = falseandret = 1withret = trueincan_pop()cppcheck
The upstream cppcheck MISRA addon has been enhanced to catch
bool <- 0/1assignments in C99 and later (cppcheck-opensource/cppcheck#8340, cppcheck-opensource/cppcheck#8388). This PR fixes the violations found by the enhanced rule.Verification