Skip to content

Set XEUS_CPP_OMP to -fopenmp (don't require openmp to be available to build time to set)#475

Merged
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:don't-require-openmp-at-built-time
Apr 13, 2026
Merged

Set XEUS_CPP_OMP to -fopenmp (don't require openmp to be available to build time to set)#475
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:don't-require-openmp-at-built-time

Conversation

@mcbarton
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.51%. Comparing base (978c52c) to head (aeef2d6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files          23       23           
  Lines        1193     1193           
  Branches      111      111           
=======================================
  Hits          877      877           
  Misses        316      316           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we have OMP tests in tree?

@mcbarton
Copy link
Copy Markdown
Collaborator Author

LGTM! Do we have OMP tests in tree?

We currently have a single test here

class BaseXCppOpenMPTests(jupyter_kernel_test.KernelTests):
. It creates 2 threads, and gets them to output their thread number in descending order. It was added just to test basic openmp functionality. I will work on adding more tests in a future PR.

@mcbarton mcbarton merged commit 3c2b9d0 into compiler-research:main Apr 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants