refactor: use FutureExt if possible#923
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors a couple of async call sites to use futures_util::FutureExt combinators (map) instead of creating new async state machines, aligning with the goal of slightly reducing per-future memory overhead in hot paths.
Changes:
- Refactor
Runtime::spawn_blockingto map theSubmitfuture output directly rather than wrapping it in anasync moveblock. - Refactor
BufReader::fill_buf’sBuffer::with(...)callback to return a mapped future instead of anasync moveclosure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| compio-runtime/src/lib.rs | Uses FutureExt::map to avoid an extra async wrapper in spawn_blocking. |
| compio-io/src/read/buf.rs | Uses FutureExt::map to avoid an extra async closure when refilling the buffer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AsakuraMizu
reviewed
May 17, 2026
Collaborator
AsakuraMizu
left a comment
There was a problem hiding this comment.
Generally LGTM, but just a minor nitpicking: why are the two files importing FutureExt at different locations?
Member
Author
|
I prefer importing at the top, but there's another |
AsakuraMizu
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small optimization to reduce memory usage.