feat: add configurable background agent roles#336
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 333 files, which is 233 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (81)
📒 Files selected for processing (333)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review Could Not Complete
|
| Options | Enabled |
|---|---|
| Bug | ✅ |
| Performance | ✅ |
| Security | ✅ |
| Business Logic | ✅ |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Code Review Could Not Complete
|
| Options | Enabled |
|---|---|
| Bug | ✅ |
| Performance | ✅ |
| Security | ✅ |
| Business Logic | ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
coordinator,dream,checkpoint_summary,memory_extractor,auto_title, andmemory_controllerroster, typed defaults/validation/merge, workspace overlays, reserved builtin identities, and live lifecycle classification.role.fallback.usedevents, workspace-aware Dream/checkpoint behavior, and a bounded transient ACP tiebreaker for genuine memory-controller ambiguity.agh roles list|show, HTTP/UDS parity for/api/roles, structured global/workspace[roles]mutation through CLI andagh__config_*, per-field provenance, lifecycle status, and actionable diagnostics.Release Notes
🎉 Features
🐛 Bug Fixes
Deep review
SHIPverdict; the source-frozen monorepo gate passed independently after all corrections.QA
Historical run status: the targeted Agent Roles run executed all six charters and fixed all five reproduced Agent Roles bugs. Its dated report remained blocked by the then-red broad Web E2E precondition; the feature-owned Roles browser journey passed.
Coverage: Dora and Ada exercised global/workspace routing, fallback boundaries, reserved-name enforcement, cross-transport projection, Settings Roles, and the default Dream pipeline.
Issues: 5 Agent Roles bugs reproduced, fixed, and retested — coordinator config path, inherited provider resolution, extractor metadata scope, bundle agent snapshot loss, and reserved bundle error mapping.
Final-review impact flag:
MS-background-role-routing,MS-background-role-fallback,MS-settings-roles-panel, andMS-016are reset tountestedbecause the final corrections changed structured root mutation, fallback configuration, invalid-form recovery, and workspace-aware Dream behavior. Historical evidence is preserved; the next QA cycle owns those rows.Full report:
2026-07-24-agent-roles.mdAGH Impact Audit
agh__config_list|get|set|unsetnow expose canonical flattenedroles.*paths and structured root-table mutation with lifecycle results; no newagh__roles_*tool IDs were introduced. Native descriptors, config value kinds, transport parity, and tests were checked.skills/agh/documents role inspection, configuration, native-tool boundaries, builtin identities, and fallback routing.Test plan
make lint— zero Go/Bun findings.make verifyafter rebasing ontoorigin/mainand synchronizing the frozen dependency graph — codegen-check, installer-check, Bun lint/typecheck/test, Web build, Go fmt/lint/race tests/build, and boundaries passed.go test -race ./internal/network -run '^TestManagerWaitInboxHonorsCancellationAndShutdown$' -count=100— 300 test nodes passed.make codegen-check, and the agent-skill integration scenario passed.Shipping notes
.githubworkflow changes are included.skeeper sync --dry-runwas not forced because its guardrail reported an unrelated 8,072-file / 273 MB plan.