Skip to content

fix: skip token exchange when no credentials configured (OSS Conductor auth) #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manan164 wants to merge 1 commit into from
Closed

fix: skip token exchange when no credentials configured (OSS Conductor auth) #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion Conductor/Client/Authentication/TokenHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ public TokenHandler()

public string GetToken(OrkesAuthenticationSettings authenticationSettings, TokenResourceApi tokenClient)
{
// OSS Conductor: if no credentials are configured, skip token exchange entirely.
if (authenticationSettings == null ||
string.IsNullOrEmpty(authenticationSettings.KeyId) ||
string.IsNullOrEmpty(authenticationSettings.KeySecret))
{
return null;
}

string token = (string)_memoryCache.Get(authenticationSettings);
if (token != null)
{
Expand All @@ -43,6 +51,14 @@ public string GetToken(OrkesAuthenticationSettings authenticationSettings, Token

public string RefreshToken(OrkesAuthenticationSettings authenticationSettings, TokenResourceApi tokenClient)
{
// OSS Conductor: if no credentials are configured, skip token exchange entirely.
if (authenticationSettings == null ||
string.IsNullOrEmpty(authenticationSettings.KeyId) ||
string.IsNullOrEmpty(authenticationSettings.KeySecret))
{
return null;
}

lock (_lockObject)
{
string token = GetTokenFromServer(authenticationSettings, tokenClient);
Expand Down Expand Up @@ -80,4 +96,4 @@ private string GetTokenFromServer(OrkesAuthenticationSettings authenticationSett
throw new Exception("Failed to refresh authentication token");
}
}
}
}
Loading