fix: persist enhancement fields and commit hash through upsert round-trips#163
Merged
Merged
Conversation
…trips upsert() rebuilt payloads from a fixed whitelist that omitted enhanced, enhanced_at, summary, and concepts — the worker's updateFields silently dropped them, so enhancements only half-applied (tags/category survived, the enhanced marker and summary vanished). mapScoredPointToEntry had the same gap plus 'commit', meaning any getById→upsert cycle (usage increments, field updates) erased the commit hash that commit-based dedup relies on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #162. With the queue routing fixed, enhancement results reached the right collection but only half-applied:
upsert()rebuilds payloads from a fixed field list that omittedenhanced,enhanced_at,summary, andconcepts, so the worker's update dropped them (tags/category survived only because they're whitelisted). Without theenhancedmarker there is no way to find unenhanced entries for backfill.mapScoredPointToEntry()had the same gap pluscommit— any getById→upsert cycle (usage increment, updateFields) erased the stored commit hash thatfindByTitleAndCommitdedup depends on.Fix: carry the four enhancement fields through
upsert()when present, and round-trip them (pluscommit) inmapScoredPointToEntry(). Regression test asserts the full round-trip.Verified: full suite green (1,134 passed), PHPStan unchanged from master (52 pre-existing).