Quite a challenge!#19
Open
joelamb wants to merge 30 commits into
Open
Conversation
- Return search results on page Multi-line description of commit, feel free to be detailed. [Ticket: X]
| searchFilmBytitle(params.query); | ||
| currentPageNum.textContent = params.pageNum; | ||
| document.querySelector('#film-details').innerHTML = ''; | ||
| e.stopPropagation(); |
Collaborator
There was a problem hiding this comment.
is stopPropagation needed?
| const prevPage = document.querySelector('#page-nav .prev'); | ||
| prevPage.addEventListener('click', e => { | ||
| e.preventDefault(); | ||
| params.pageNum > 1 ? params.pageNum-- : false; // Prevent previous page returning negative page number |
Collaborator
There was a problem hiding this comment.
if might work better here since we do not need the false
Author
There was a problem hiding this comment.
Resolved: if() substituted for ternary.
|
|
||
| /* infinite scroll */ | ||
| const infiniteScroll = () => { | ||
| const trigger = document.querySelector('#'); |
Author
There was a problem hiding this comment.
Resolved. It's a TODO feature to add infinite scroll to search results
Collaborator
|
Good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localStorage proved very challenging, more time spent planning the structure of the app would have made development faster, but still a really enjoyable project. Just wish I could have got more done.