Slacker News App#10
Open
HTLuff wants to merge 3 commits into
Open
Conversation
HTLuff
commented
Jun 18, 2018
HTLuff
commented
- Lastest Tech News button
- Invert colours button
- Hide/Show description button
dmitrigrabov
reviewed
Jul 1, 2018
| const appScreen = document.querySelector('#app'); | ||
| const descriptionToggle = document.querySelector('#descrption-toggle'); | ||
|
|
||
| function createURL(indvCategory){ |
Contributor
There was a problem hiding this comment.
like the helper function use
dmitrigrabov
reviewed
Jul 1, 2018
| return `https://newsapi.org/v2/top-headlines?category=technology&country=gb&apiKey=${newAPIKey}&pagesize=5`; | ||
| } | ||
|
|
||
| function display(newsData){ |
Contributor
There was a problem hiding this comment.
display logic nicely broken out into own function
dmitrigrabov
reviewed
Jul 1, 2018
| const newsDesc = Array.from(document.getElementsByClassName('news-desc')); | ||
| if(descriptionToggle.className.match(/(?:|\s) toggle-on(?!\s)/)){ | ||
| newsDesc.forEach(function(el){ | ||
| el.className = el.className.replace(' toggle-on', ''); |
Contributor
There was a problem hiding this comment.
toggleClass would work well here https://developer.mozilla.org/en-US/docs/Web/API/Element/classList
dmitrigrabov
reviewed
Jul 1, 2018
| } | ||
|
|
||
| .clicked { | ||
| filter: invert(100%); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.