100% complete#13
Open
jamesmcallister wants to merge 9 commits into
Open
Conversation
dmitrigrabov
reviewed
Jul 1, 2018
| import { SingleArticle } from "./singleArticle"; | ||
|
|
||
| export const ArticleList = ({ articles, title }) => ( | ||
| <React.Fragment> |
dmitrigrabov
reviewed
Jul 1, 2018
| export const ArticleList = ({ articles, title }) => ( | ||
| <React.Fragment> | ||
| <h1 className="articleList__title"> {title} </h1> | ||
| {articles.map((data, i) => <SingleArticle key={i} {...data} />)} |
Contributor
There was a problem hiding this comment.
using index as key might cause weird bugs
dmitrigrabov
reviewed
Jul 1, 2018
| <p className="article__description">{description}</p> | ||
| <div className="article__publishedAt"> | ||
| Posted | ||
| {" " + distanceInWordsToNow(publishedAt)} ago |
dmitrigrabov
reviewed
Jul 1, 2018
| ); | ||
| }, 30000); | ||
| } | ||
| // fetchClick(event) { |
Contributor
There was a problem hiding this comment.
Avoid committing commented out code
dmitrigrabov
reviewed
Jul 1, 2018
| <button type="submit">Submit me</button> | ||
| </form> */} | ||
| <article className="article__list"> | ||
| {this.state.loading |
dmitrigrabov
reviewed
Jul 1, 2018
| @@ -0,0 +1,32 @@ | |||
| const apiKey = "e3f2c5f01b3a456eb81a95a2f0e85fc2"; | |||
Contributor
There was a problem hiding this comment.
like how the key is broken out into own variable
dmitrigrabov
reviewed
Jul 1, 2018
| .then(response => response.json()) | ||
| .then(data => ({ | ||
| title: "Top Headlines - USA", | ||
| articles: data.articles.filter(data => data.urlToImage) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.