Fix RESOURCE_EXHAUSTED error code from 13 to 8#605
Open
nixpanic wants to merge 1 commit into
Open
Conversation
Corrected two instances where RESOURCE_EXHAUSTED was incorrectly listed as gRPC code 13 instead of the correct code 8: - Line 2040: Not enough space to create snapshot - Line 3086: Not enough space to create group snapshot The correct gRPC error code for RESOURCE_EXHAUSTED is 8, not 13 (which is INTERNAL).
Contributor
Author
|
Not sure why the build test fails... The protobuf file should not have been modified by the change in the text, there is no reason to rebuild anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/bugfix
What this PR does / why we need it:
Inconsistent/incorrect error-code can cause confusion on what is intended to happen.
Special notes for your reviewer:
This should not cause problems for CSI-driver implementers. The
RESOURCE_EXHAUSTEDerror description is clear enough. Code 13 would beINTERNAL, which does not make much sense to return when the description is read.Does this PR introduce an API-breaking change?: