Update module github.com/opencontainers/selinux to v1.14.1#841
Merged
Conversation
common/pkg/config/default.go uses selinuxEnabled wrapper which is no longer needed since on !linux selinux.GetEnabled always returns false. Besides, common/pkg/config/default.go already calls selinux.GetEnabled directly in another place (SecurityOptions) for quite some time. Remove the wrapper. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
NOTE we deliberately ignore selinux.ErrMCSAlreadyExists from selinux.ReserveLabelV2 in storage, because we are not interested in whether the label is unique -- we are interested in label being reserved. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
github-actions
Bot
added
storage
1 task
mtrmac
reviewed
May 12, 2026
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
(I don’t have much of an opinion on correctness of the ErrMCSAlreadyExists logic, but at least it is equivalent to what we have now.)
mtrmac
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #823.
NOTE we deliberately ignore selinux.ErrMCSAlreadyExists from
selinux.ReserveLabelV2 in storage, because we are not interested in
whether the label is unique -- we are interested in label being
reserved.