- podman_compose.py - Replaces the single batched podman wait cal… - #1479
Merged
Conversation
Contributor
Author
|
This is a follow up, split out of: #1476 |
allen-munsch
marked this pull request as ready for review
June 20, 2026 17:10
p12tic
reviewed
Jun 20, 2026
p12tic
requested changes
Jun 20, 2026
p12tic
left a comment
p12tic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just please clean up test assertions.
allen-munsch
force-pushed
the
ux/per-container-wait
branch
from
June 20, 2026 18:06
a33b05e to
195835b
Compare
Contributor
Author
|
took >10 seconds on the runner possibly some falkiness? |
p12tic
approved these changes
Jun 22, 2026
p12tic
force-pushed
the
ux/per-container-wait
branch
from
June 22, 2026 20:54
195835b to
4378250
Compare
Collaborator
|
Rebased to see if flaky test resolves itself. |
p12tic
force-pushed
the
ux/per-container-wait
branch
from
July 14, 2026 12:06
4378250 to
527b0ff
Compare
Collaborator
|
Rebased to fix merge conflict. |
Contributor
Author
|
i'll take a loook |
….gather` waits. Each container gets its own `podman wait --condition=<cond> <container>` call with independent retry loops, enabling healthcheck support on podman >= 4.6.0. - `tests/unit/test_depends_on.py` - 8 new async unit tests covering: - Empty deps - early return, no waits - Single condition, two containers - two individual `podman wait` calls - Two conditions, one container each - correct `--condition` per call - `CalledProcessError` on first call - retry, eventually succeeds - HEALTHY dep on podman 4.5.0 - skipped (no wait calls) - UNHEALTHY dep on podman 4.5.0 - skipped (mirror) - HEALTHY on podman 4.6.0 - waits normally - `podman_version=None` - healthcheck proceeds (short-circuit edge case) - `newsfragments/check_dep_conditions_asyncio_gather.change` - changelog fragment Signed-off-by: allen-munsch <james.a.munsch@gmail.com>
allen-munsch
force-pushed
the
ux/per-container-wait
branch
from
July 14, 2026 19:41
527b0ff to
855794e
Compare
Collaborator
Oh, it was already OK. I just left the tests to run and didn't return back. Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l in
check_dep_conditionswithper-container
asyncio.gatherwaits. Each container gets its ownpodman wait --condition=<cond> <container>call with independent retry loops, enabling healthcheck support on podman >= 4.6.0.tests/unit/test_depends_on.py- 8 new async unit tests covering:podman waitcalls--conditionper callCalledProcessErroron first call - retry, eventually succeedspodman_version=None- healthcheck proceeds (short-circuit edge case)newsfragments/check_dep_conditions_asyncio_gather.change- changelog fragment