-
Notifications
You must be signed in to change notification settings - Fork 0
feat(5736): add GetVariantMetadataTags; deprecate GetDataCsvariantsAttribute #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OMpawar-21
wants to merge
3
commits into
development
Choose a base branch
from
enhc/DX-5736
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: Unit Test | ||
| on: | ||
| pull_request: | ||
| push: | ||
|
|
||
| jobs: | ||
| unit-test: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4.2.2 | ||
| - name: Setup .NET Core @ Latest | ||
| uses: actions/setup-dotnet@v4.3.0 | ||
| - name: Build solution and run unit tests | ||
| run: sh ./Scripts/run-unit-test-case.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -337,7 +337,13 @@ public static JArray GetVariantAliases(JArray entries, string contentTypeUid) | |
| return variantResults; | ||
| } | ||
|
|
||
| public static JObject GetDataCsvariantsAttribute(JObject entry, string contentTypeUid) | ||
| /// <summary> | ||
| /// Builds the JSON object used for the <c>data-csvariants</c> HTML attribute payload from a single entry. | ||
| /// </summary> | ||
| /// <param name="entry">Entry JSON (e.g. from the Delivery API), or <c>null</c> to produce an empty payload.</param> | ||
| /// <param name="contentTypeUid">Content type UID for the entry.</param> | ||
| /// <returns>A <see cref="JObject"/> with a <c>data-csvariants</c> key whose value is a compact JSON array string.</returns> | ||
| public static JObject GetVariantMetadataTags(JObject entry, string contentTypeUid) | ||
| { | ||
| if (entry == null) | ||
| { | ||
|
|
@@ -347,10 +353,16 @@ public static JObject GetDataCsvariantsAttribute(JObject entry, string contentTy | |
| } | ||
| JArray entries = new JArray(); | ||
| entries.Add(entry); | ||
| return GetDataCsvariantsAttribute(entries, contentTypeUid); | ||
| return GetVariantMetadataTags(entries, contentTypeUid); | ||
|
Comment on lines
-350
to
+356
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check with @reeshika-h whether to remove the method or not |
||
| } | ||
|
|
||
| public static JObject GetDataCsvariantsAttribute(JArray entries, string contentTypeUid) | ||
| /// <summary> | ||
| /// Builds the JSON object used for the <c>data-csvariants</c> HTML attribute payload from multiple entries. | ||
| /// </summary> | ||
| /// <param name="entries">Array of entry JSON objects, or <c>null</c> to produce an empty payload.</param> | ||
| /// <param name="contentTypeUid">Content type UID shared by these entries.</param> | ||
| /// <returns>A <see cref="JObject"/> with a <c>data-csvariants</c> key whose value is a compact JSON array string.</returns> | ||
| public static JObject GetVariantMetadataTags(JArray entries, string contentTypeUid) | ||
| { | ||
| JObject result = new JObject(); | ||
| if (entries == null) | ||
|
|
@@ -368,6 +380,24 @@ public static JObject GetDataCsvariantsAttribute(JArray entries, string contentT | |
| return result; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Prefer <see cref="GetVariantMetadataTags(JObject, string)"/>. This alias exists for backward compatibility and will be removed in a future major release. | ||
| /// </summary> | ||
| [Obsolete("Use GetVariantMetadataTags instead. This method will be removed in a future major release.")] | ||
| public static JObject GetDataCsvariantsAttribute(JObject entry, string contentTypeUid) | ||
| { | ||
| return GetVariantMetadataTags(entry, contentTypeUid); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Prefer <see cref="GetVariantMetadataTags(JArray, string)"/>. This alias exists for backward compatibility and will be removed in a future major release. | ||
| /// </summary> | ||
| [Obsolete("Use GetVariantMetadataTags instead. This method will be removed in a future major release.")] | ||
| public static JObject GetDataCsvariantsAttribute(JArray entries, string contentTypeUid) | ||
| { | ||
| return GetVariantMetadataTags(entries, contentTypeUid); | ||
| } | ||
|
|
||
| private static JArray ExtractVariantAliasesFromEntry(JObject entry) | ||
| { | ||
| JArray variantArray = new JArray(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <Version>1.1.0</Version> | ||
| <Version>1.2.0</Version> | ||
| </PropertyGroup> | ||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change