Merged
Conversation
…to feature/wordpress
…package-lock.json
…s and add license information for several packages
…grade several dependencies
vikrantraut
previously approved these changes
Mar 30, 2026
… handle console errors
…nt dependencies in package-lock.json
…d text-table in package-lock.json
… license information for dev dependencies
vikrantraut
previously approved these changes
Mar 30, 2026
…dependencies, and add license information for several packages
…ms and architectures with new @parcel/watcher entries
…nt dependencies in package-lock.json
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the migration UI to carry and display additional WordPress/SQL-related configuration (MySQL connection details and assets config) as part of the uploaded file metadata, while also refreshing several dependencies/lockfiles across the repo.
Changes:
- Extend
FileDetailsand migration state mapping to includemysqlconnection info andassetsConfigfields. - Update legacy CMS upload/validation UI to read/write the new
mysqlshape and adjust when Redux state is dispatched/refreshed. - Bump dependency versions and regenerate lockfiles (UI + upload-api), plus add an
undicioverride in the API package.
Reviewed changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/package.json | Updates @typescript-eslint plugin/parser versions. |
| upload-api/package-lock.json | Lockfile refresh to match dependency updates. |
| upload-api/migration-aem/package-lock.json | Lockfile refresh/removals for migration-aem package. |
| ui/tests/unit/store/authSlice.test.ts | Silences console.error during an error-path test. |
| ui/src/pages/Migration/index.tsx | Maps config/project data into migration state, now including mysql + assetsConfig. |
| ui/src/context/app/app.interface.ts | Renames FileDetails MySQL field to mysql. |
| ui/src/components/LegacyCms/Actions/LoadUploadFile.tsx | Updates MySQL rendering and changes dispatch/effect behavior during validation. |
| ui/package.json | Bumps @contentstack/venus-components and adds @testing-library/dom. |
| ui/package-lock.json | Lockfile refresh to match UI dependency updates. |
| api/package.json | Adds an undici override entry. |
Files not reviewed (3)
- ui/package-lock.json: Language not supported
- upload-api/migration-aem/package-lock.json: Language not supported
- upload-api/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
ui/src/context/app/app.interface.ts:64
- This interface renames
mySQLDetailstomysql, but there is still code constructing/readingfile_details.mySQLDetails(e.g.,ui/src/components/LegacyCms/Actions/LoadSelectCms.tsx:153). That will cause type errors and likely runtime missing data. Either update all remaining call sites tomysql, or keep backwards compatibility by supporting both properties during a transition.
bucketName?: string;
bucketKey?: string;
};
mysql?: {
host?: string;
user?: string;
database?: string;
port?: number;
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or various architectures and operating systems
…ncy and adjust its version to 2.8.3
umeshmore45
approved these changes
Mar 31, 2026
Contributor
|
@vikrantraut-cstk please approve |
vikrantraut
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.