Repository navigation
fix(util): fix off-by-one slice and missing block handling in ReadIOAdapter - #96
Open
Adityakk9031 wants to merge 1 commit into
Open
Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While inspecting
ReadIOAdapter, noticed two issues with chunk reads:read_enumwas usingslice!(..max_len), which takes an inclusive range (0..max_len) and ends up readingmax_len + 1bytes when there are enough bytes buffered. Switching this toslice!(0, max_len)ensures we don't exceed the requested length.read,.tap(&@blk)blows up withLocalJumpError (no block given)if the adapter was initialized without a block. Using.tap { @blk&.call(_1) }avoids yieldingnil.Added a couple of unit tests covering chunked reads and blockless initialization.