Conversation
ocots
marked this pull request as draft
April 15, 2026 15:52
Contributor
|
Breakage test results
|
Member
|
output here |
- Move illustrative example to companion repository (joss-oc-example) - Add bib entry for Zenodo DOI 10.5281/zenodo.19663650 - Simplify Illustrative Example section to reference companion repo - Remove orphaned ## heading in State of the Field section - Delete plot.svg (no longer needed)
…Testing and quality assurance paragraph to JOSS paper
…k for OptimalControlProblems.jl
…TING.md and badges
Update README (2026-06-04) with latest ABOUT.md, INSTALL.md, CONTRIBUTING.md and badges
- joss/paper.md: append sentence to the Indirect methods bullet in the Software Design section noting that indirect methods are currently limited to Hamiltonian flows (u(x,p)) and that support for non-Hamiltonian flows is under active development - docs/src/manual-flow-ocp.md: add a prominent note admonition at the top of the flow-from-OCP tutorial, before any code example, explaining the same limitation and listing the planned extensions (open-loop u(t) and state-feedback u(x))
- AI disclosure: name Claude Sonnet 4.6 and Claude Opus 4.8 by Anthropic
- GPU claims: replace "seamless" with accurate language; clarify NVIDIA-only
constraint and ExaModels + MadNLP requirement in Summary, State of the
Field, and GPU trade-off sections
- JuliaCon 2023: add @caillau2023juliacon entry to paper.bib and cite it
in the Research Impact section
- "our plan is": rephrase to present tense ("our package provides")
- MATLAB: already fixed by author (Matlab -> MATLAB in State of the Field)
Per citation convention, package names with references first appear in the following paragraph; the Summary now only states the NVIDIA hardware constraint without repeating the package names.
- Uniform styling: hyperlink and cite every .jl package / tool at its first mention in each section (ForwardDiff.jl, DifferentiationInterface.jl, NonlinearSolve.jl, ADNLPModels, ExaModels, MadNLP, Knitro, IPOPT, NLPModelsIpopt.jl, DifferentialEquations.jl, and the Julia packages bullet of State of the Field). - Add a MINPACK citation (More, Garbow & Hillstrom 1980, ANL-80-74). - Cite IPOPT directly in the "Modelers and solvers" paragraph. - joss-oc-example: point at the Zenodo all-versions (concept) DOI 10.5281/zenodo.19663649 so the reference always resolves to the latest release; drop the now-misleading version field. - Add a "Problem Class" section making the supported problem class explicit (Bolza/Mayer/Lagrange, free initial/final time, boundary, variable, path and mixed constraints, box constraints, autonomous and non-autonomous dynamics) and stating what is out of scope (multiphase, DAEs, hybrid/nonsmooth systems). - Cite the previously unused QuantumControl.jl bib entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Every package / tool is hyperlinked at each of its occurrences, while the bibliography tag [@key] is given only at the first occurrence. Adds the missing hyperlinks (InfiniteOpt.jl, JuMP, ADNLPModels, ExaModels, MadNLP, CUDSS) and drops the duplicated tags (@Patterson2014, @Verschueren2021, @Andersson2019, @arnstrom2022daqp, @Gagnon_*, @pulsipher2022unifying, @QuantumControl_jl, @shin2023accelerating, @shin*, @ADNLPModels_jl, @OptimalControlProblems_jl, @Wachter2006, @rackauckas2017*). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Align .zenodo.json DOI with the concept DOI already used in CITATION.bib/CITATION.cff (10.5281/zenodo.13336563) - Remove unused Documenter/NLPModels/SolverCore from Project.toml; move ADNLPModels to [extras]/[targets] since it is only needed by tests for now (CTSolversADNLPModels extension not yet in the pinned CTSolvers version) - Remove unused DataFrames dependency from docs/Project.toml - Explain why NLPModelsIpopt/Plots must be loaded (extension triggers) in README.md and docs/src/index.md basic usage examples - Drop pinned Julia versions in CI.yml so CPU and GPU jobs both use the reusable workflow's default (1.10 and 1.12) instead of diverging (1.12 vs floating 1) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SolverCore was fully removed as unused, but it is used by test/suite/reexport/test_ctsolvers.jl (AbstractExecutionStats signature check) — same situation as ADNLPModels. Move it to [extras]/[targets] instead of dropping it entirely, and loosen its compat bound to "0.3" to match the other extras entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…1.11
On Julia 1.10, type inference for _extract_kwarg gives the wider
Union{Nothing, AbstractDiscretizer} instead of the concrete runtime
type, making @inferred fail — a compiler precision difference, not
a logic bug. Same pattern already used in CTFlows.jl for an
analogous allocation check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
joss: address reviewer Tangi
ocots
added
run ci kkt-runner
This was referenced Aug 1, 2026
ocots
marked this pull request as ready for review
August 2, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.