Feature: Partial cancel#9
Open
vsoch wants to merge 4 commits into
Open
Conversation
I can format the jobspec correctly, but then when the formatting errors go away it silently returns no response and no errors, so I cannot debug further. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This is the start of work for partial cancel. Specifically, we needed to refactor the match and jobspec to ask for resources on the level of a core for a slot (and not node as previously done). This means we need to get back the graph and parse the cores into units based on the size of the slot (pod). Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of work for partial cancel. Specifically, we needed to refactor the match and jobspec to ask for resources on the level of a core for a slot (and not node as previously done). This means we need to get back the graph and parse the cores into units based on the size of the slot (pod).
I tested doing a satisfy and then match -> cancel to attempt schedule with a constraint, and the latter worked through the cancel but the constraint addition resulted in no allocation and no obvious errors. I'm next going to work on the right way to do the partial cancel when the job comes back - likely we will want to prepare a jobspec with the resource to remove for each pod (as a label / annotation or similar) so it can be just grabbed and used when the event is received.