Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
We should have a common base with worker functions to make it cleaner for a hub to serve as a worker. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
testing, and I did not have the agent tools. This should fix it. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
dual-mode
branch
3 times, most recently
from
cab4d53 to
4140072
Compare
This will make it much easier for a user to see what was called. We can do this for negotiation too. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
dual-mode
branch
2 times, most recently
from
6851aa8 to
9428aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am combining the hub and worker (better code structure) to have shared functions when a hub serves as a worker too.