Repository navigation
Fix passkey deletion encoding and preserve authorization diagnostics - #3
Merged
Merged
Conversation
…ignal call best-effort
…ignal call best-effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passkey deletion could succeed on the backend but return an error when the subsequent Signal API call tried to decode base64url identifiers as standard base64. Decode both the user handle and accepted credential IDs correctly, and keep signaling best-effort so a signal failure preserves the loaded passkey list.
Login error events now use the complete authorization error description, preserving the error classification and native diagnostics. Signal decoding errors identify the failing field, zero-based credential index and encoded byte length without retaining raw identifiers. Signal events also include the list mode and accepted credential count.
Validation:
Release preparation: