Skip to content

Fix passkey deletion encoding and preserve authorization diagnostics - #3

Merged
incorbador merged 5 commits into
mainfrom
fix/signal-base64url-decoding
Sep 7, 2026
Merged

incorbador merged 5 commits into
mainfrom
fix/signal-base64url-decoding

Conversation

@incorbador

@incorbador incorbador commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Passkey deletion could succeed on the backend but return an error when the subsequent Signal API call tried to decode base64url identifiers as standard base64. Decode both the user handle and accepted credential IDs correctly, and keep signaling best-effort so a signal failure preserves the loaded passkey list.

Login error events now use the complete authorization error description, preserving the error classification and native diagnostics. Signal decoding errors identify the failing field, zero-based credential index and encoded byte length without retaining raw identifiers. Signal events also include the list mode and accepted credential count.

Validation:

  • All 11 SDK tests pass on the iOS 26 simulator against published SimpleAuthenticationServices 1.2.1, including parameterized cases for both login paths, native and decoding failures, empty credential lists, and deletion succeeding even when signal reporting or telemetry fails.
  • ConnectExample builds successfully for the iOS Simulator with code signing disabled.
  • Regression tests exercise the actual plugin arguments and encoded telemetry request bodies with isolated controller/API stubs.
  • An SDK test workflow now runs on pull requests using Xcode 26.0.1.

Release preparation:

  • Require published SimpleAuthenticationServices 1.2.1; both Package.resolved files select its release commit 875db0aa866b95dc6561193cfc9a558f249e447c.
  • The temporary dependency revision pin has been removed.
  • The SDK changelog is prepared for version 1.3.2, dated 2026-09-07.
  • Remaining release steps: review and merge this PR, then publish SDK tag v1.3.2 from the merged commit.

@incorbador incorbador changed the title Fix base64url decoding in signalAllAcceptedCredentials and make the s… Fix passkey deletion encoding and preserve authorization diagnostics Sep 7, 2026
@incorbador
incorbador merged commit 6db6f36 into main Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant