Skip to content

feat/DS-15910_universal-modal_scroll#2159

Merged
fulcanellee merged 7 commits intomasterfrom
feat/DS-15910_universal-modal_scroll
Apr 15, 2026
Merged

feat/DS-15910_universal-modal_scroll#2159
fulcanellee merged 7 commits intomasterfrom
feat/DS-15910_universal-modal_scroll

Conversation

@fulcanellee
Copy link
Copy Markdown
Contributor

DS-15910

BaseModal
  • Исправлен проброс пропсов для backdrop
UniversalModal
  • Добавлена механика доступа к странице при открытом модальном окне и скрытом оверлее (страницу можно скроллить и взаимодействовать с элементами)
  • При скрытом оверлее по прежнему можно управлять блокировкой фокуса на компоненте или делать его доступным для всего контента (disableFocusLock)
  • Скролл при скрытом оверлее всегда в разблокированном состоянии. Если ваш кейс требует блокировку скролла при скрытом оверлее - сообщите команде поддержки
  • Пропсы для backdrop не будут работать при скрытом оверлее, так как для этого кейса backdrop не рендерится на странице
  • Улучшена логика скролла внутри компонента, когда событе скролла происходит по оверлею
overlay.mov

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 6, 2026

🦋 Changeset detected

Latest commit: 4e1d76f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@alfalab/core-components Minor
@alfalab/core-components-universal-modal Minor
@alfalab/core-components-base-modal Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-drawer Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-select Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fulcanellee fulcanellee changed the title Feat/ds 15910 universal modal scroll feat/DS-15910_universal-modal_scroll Apr 6, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Report for CI Build 24383251342

Coverage increased (+0.08%) to 82.003%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 3 uncovered changes across 1 file (14 of 17 lines covered, 82.35%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
packages/universal-modal/src/desktop/hooks/use-scrollable-container-ref.ts 9 6 66.67%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11604
Covered Lines: 9596
Line Coverage: 82.7%
Relevant Branches: 2176
Covered Branches: 1704
Branch Coverage: 78.31%
Branches in Coverage %: Yes
Coverage Strength: 230.48 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Demo build (default)

https://core-ds.github.io/core-components/2159

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Demo build (alfasans)

https://core-ds.github.io/core-components/2159-alfasans

@fulcanellee fulcanellee force-pushed the feat/DS-15910_universal-modal_scroll branch from 3ed084f to e1e2294 Compare April 6, 2026 13:53
@fulcanellee
Copy link
Copy Markdown
Contributor Author

fulcanellee commented Apr 14, 2026

@hextion глянь плиз, нужно другой таск с этим компонентом взять. могут конфликты быть

@fulcanellee fulcanellee merged commit cec531b into master Apr 15, 2026
55 of 57 checks passed
@fulcanellee fulcanellee deleted the feat/DS-15910_universal-modal_scroll branch April 15, 2026 06:03
@core-ds-app core-ds-app bot mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants