Repository navigation
chore(deps): override minimatch to the patched 11.0.x - #138
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dependabot security-update job for
minimatchkept failing, so the known-vulnerable copies of the package stayed in the lockfile and no patched version ever landed. The resolved dependency tree now carries a single patched minimatch, so the security update can complete and the job stops failing.Why this fix
Dependabot's security-update job (run 41536599089) reported
security_update_not_possible. Three eslint-family packages pin minimatch to ranges that top out below the patched 11.0.1, so the resolver could only reach 10.2.5 while the earliest fixed version is 11.0.1, and the job failed. The override raises every minimatch copy in the tree to 11.0.x, so no vulnerable copy remains and the update can complete. The main risk is that minimatch 11 is a major jump; eslint and typescript-eslint use the CommonJS and named exports that 11 keeps, and lint runs clean against it. An unrelated@humanfs/nodeadvisory is noted on the issue.Fix walkthrough
Watch the fix explained (1:34). Recorded for commit
75bd2d8924fe8fa7d62d0932b510de64fdd77481.Out of scope
eslintandtypescript-eslint: already at their latest resolved versions, so no version bump could raise minimatch.@humanfs/node0.16.7: separate moderate advisory (GHSA-p498-v437-472g), recorded as a follow-up rather than bundled here.Production impact
Check that the cli dev dependency tree carries no vulnerable minimatch
The change only touches the dependency manifest and lockfile of a public npm CLI repository; minimatch is a transitive dev dependency of eslint and typescript-eslint and is not on the shipped runtime path. The repository node
code.repository:coreplanelabs/clihas no deploy edges, and a clean install, lint, test and build all pass on the new tree.Checked and not affected (1)
cliObservability
security_update_not_possiblewhen it fails and completes silently when it succeeds. No application telemetry is involved; minimatch is a dev-only dependency and the bundled CLI artifact is unchanged.Polylane assessed this pull request at
75bd2d8.Causal chain
2 files changed (+34/-61)
package-lock.json: modified, +31/-61package.json: modified, +3/-0Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment.