Skip to content

feat(connect): connect Blacksmith from the CLI - #139

Merged
nwm-54 merged 2 commits into
mainfrom
feat/connect-blacksmith
Nov 2, 2026
Merged

nwm-54 merged 2 commits into
mainfrom
feat/connect-blacksmith

Conversation

@nwm-54

@nwm-54 nwm-54 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

polylane integration connect --type blacksmith --api-token <token> --organization <login> connects the selected Blacksmith organisation. The interactive flow guides an administrator through creating its organisation token. Blacksmith appears in the CI/CD picker alongside Depot and CircleCI.

The branch includes the latest merged CircleCI connect flow. The merge conflict is resolved with both integrations, flags, examples, and tests intact. The Blacksmith guide link points to /integrations/blacksmith.

Validation: code generation, typecheck, lint, and all 622 tests pass. New offline tests cover missing-token guidance, a missing organisation flag, and the exact connect request body. Independent review found no remaining blocking issue. A real Blacksmith connection requires an organisation token and remains a manual check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polylane

polylane Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Warning

Polylane could not verify the production impact of this pull request.

Checked the full diff: it only adds a Blacksmith connect type and a --organization flag to the CLI client. No attached cloud account runs src/commands/integration/connect.ts, and the exact-match parser keeps --organization distinct from --organization-id.

View the full analysis →

Also considered · 2 refuted
  • Refuted · New --organization flag collides with --organization-id and breaks other connect flows · The parser matches exact flag names with no prefix matching, so --organization cannot capture --organization-id or --organization-api-key; each resolves its own key and existing connect flows are unchanged.
  • Refuted · Blacksmith connect sends a body the production API rejects · A wrong body on a new, opt-in type is a 400 returned to the calling client only; it cannot degrade a deployed resource, since no attached account runs the CLI and the change alters no existing connect path.
Analysed against 8 cloud accounts and 1 repository
  • Cloud accounts: coreplane-prod, baseberry-uat, coreplane-infra, coreplane, coreplane-gtm, 251714435813, Polylane, nominal-493716
  • Repository: coreplanelabs/cli

View in Polylane Pause assessments

Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to.

Connect resources

Polylane analysed 84e6bef for production impact. You can ask follow-ups by mentioning @polylane in a comment.

Rate this review: 👍 helpful · 👎 not helpful · 😕 confusing

Previous verdicts (1)
Head Verdict Analysis
a201502 Production impact not verified analysis

@nwm-54 nwm-54 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Blacksmith connect sends the documented token and organisation fields, and the merged CircleCI flow remains intact. The broken guide link is fixed. Independent review found no remaining blocking issue. Code generation, typecheck, lint, and all 622 offline tests pass. A live Blacksmith connection remains a manual check.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: nwm-54 reviewed this PR and posted an LGTM verdict (see its review). A repo admin enabled this via the auto-approve workflow.

@nwm-54
nwm-54 merged commit 8f589b5 into main Nov 2, 2026
5 checks passed
@nwm-54
nwm-54 deleted the feat/connect-blacksmith branch November 2, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant