perf: optimise VM runtime execution loop#7
Merged
Conversation
Agent-Logs-Url: https://github.com/corepunch/armvm/sessions/b59e6d5e-873b-4db5-8bb6-00ddcd6e196f Co-authored-by: corepunch <83646194+corepunch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
corepunch
April 15, 2026 06:42
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VM interpreter loop contained several avoidable overheads on every instruction fetch, making runtime slower than necessary.
Changes
Remove dead division per instruction —
DWORD line = vm->location / 4 + 1was computed every loop iteration but never used.OPCOND_ALfast-path —_condition()(a function call + switch dispatch) was invoked unconditionally for every instruction. Since the vast majority of ARM instructions use the "always" condition (0b1110), the condition field is now checked inline first;_condition()is only called for genuinely conditional instructions.__builtin_expecthints the branch predictor accordingly.Mark internal helpers
static—_condition,_calcshift,_calcimmediate, allexec_*helpers, andexec_instructionwere externally visible despite being purely internal. Withoutstatic, the compiler must preserve them as addressable symbols and is conservative about inlining. This lets-O2inline them freely.Fix UB in
_calcimmediate()— when the rotation field is zero, the old code evaluatedImm << 32, which is undefined behaviour for a 32-bit type. Added an early return for the zero-rotation case.