Skip to content

flags: respect explicit --listen when metrics-endpoint is set #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gecube wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flags: respect explicit --listen when metrics-endpoint is set #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ func init() {
platformEndpoints(u)
}

if *MetricsEndpoint != nil {
if *MetricsEndpoint != nil && *ListenAddress == defaultListenAddress {
// In remote-write mode the built-in HTTP server is only needed for the
// agent's own metrics, so bind it to loopback by default. Respect an
// explicitly configured --listen/LISTEN so /metrics can also be scraped
// directly (e.g. by an external Prometheus alongside remote write).
*ListenAddress = "127.0.0.1:10300"
}
}