upgrade prometheus 3.9.1#7535
Merged
friedrichg merged 10 commits intoJul 3, 2026
Merged
Conversation
dosubot
Bot
added
dependencies
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
10 times, most recently
from
f1a535a to
e675cf9
Compare
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
e675cf9 to
06fc626
Compare
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
540cedf to
d763c33
Compare
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
d763c33 to
8c8d384
Compare
friedrichg
reviewed
Jun 21, 2026
| // evaluate each lazy matcher against the relevant label value. A per-matcher, | ||
| // per-value cache avoids running the same regex against the same string more | ||
| // than once, which is particularly effective when many series share label values. | ||
| func (c *blocksPostingsForMatchersCache) fetchWithLazyMatchers(ctx context.Context, ix tsdb.IndexReader, selectMs, lazyMs []*labels.Matcher) ([]storage.SeriesRef, int64, error) { |
Member
There was a problem hiding this comment.
I would be nice to see how the benchmark changes with this change
go test -bench=BenchmarkIngester_LazyPosting -benchmem -run=^$ -count=5 ./pkg/ingester/...
Not a blocker since, this flag is experimental.
Maybe @alanprot can also chime in here
Member
Author
There was a problem hiding this comment.
@friedrichg
I ran it and noticed the performance is a little bit worse.
I optimized it in db47605, and it showed similar results.
I added the results to the PR description.
Contributor
There was a problem hiding this comment.
@SungJin1212 Can you add upstream prometheus PR reference for this change? I am trying to understand why we have to call ix.Series now.
Contributor
There was a problem hiding this comment.
OK I think I found it prometheus/prometheus#17679
| // Wait until a run has been completed on each compactor | ||
| for _, c := range compactors { | ||
| cortex_testutil.Poll(t, 120*time.Second, true, func() any { | ||
| cortex_testutil.Poll(t, 240*time.Second, true, func() any { |
Member
There was a problem hiding this comment.
Is this absolutely necessary? why is it taking longer now?
Member
Author
There was a problem hiding this comment.
The #7617 tackles this flaky test. On ARM64, this test is so slow.
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
74a5df5 to
21da3bd
Compare
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
7f74877 to
07e90e6
Compare
sandy2008
approved these changes
Jun 28, 2026
Contributor
|
LGTM! |
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
07e90e6 to
7954517
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
…s for optimization Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
update-prometheus-3.9.1
branch
from
7954517 to
1fd0c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Prometheus version to 3.9.1
BenchmarkIngester_LazyPostingBenchmark resultWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags