Verify native histograms with rate.Inf and zero burst#7662
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
dosubot
Bot
added
component/distributor
go
| {nhSamples: 1000, expectedError: nil, expectedNHDiscardedSampleMetricValue: 0}, | ||
| {nhSamples: 5000, expectedError: nil, expectedNHDiscardedSampleMetricValue: 0}, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we add a test for the globalStrategyNativeHistogram.Limit() case as well?
"global strategy: unlimited native histogram rate (Inf) with zero burst should always accept NH samples": {
distributors: 2,
ingestionRateStrategy: validation.GlobalIngestionRateStrategy,
ingestionRate: 100000,
ingestionBurstSize: 100000,
nativeHistogramIngestionRate: float64(rate.Inf),
nativeHistogramIngestionBurstSize: 0,
pushes: []testPush{
{nhSamples: 1000, expectedError: nil, expectedNHDiscardedSampleMetricValue: 0},
{nhSamples: 5000, expectedError: nil, expectedNHDiscardedSampleMetricValue: 0},
},
}
There was a problem hiding this comment.
Thanks for the comment :D
I don't think it's necessary to add it here because it returns rate.Inf directly and never divides by the number of distributors when the nativeHistogramIngestionRateis rate.Inf.
2 participants
What this PR does:
This PR verifies that native histogram ingestion works correctly when using
rate.Infand a zero burst rate.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags