fix: duplicate DB rows after SOAP generation + README update#6
Merged
Conversation
The _play_audio_async method now wraps _play_audio_blocking in a _safe_play closure for error handling. Update test to verify thread creation without asserting exact target/args of the closure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… codebase Fix recording_id attribute mismatch causing duplicate database entries: - _on_queue_completion now sets both _current_recording_id (private) and current_recording_id (public) so downstream generators update existing rows instead of inserting new ones - Remove redundant re-write of transcript/soap_note/audio_path in completion callback (already saved by task_executor_mixin), which also fixed audio_path being overwritten with empty string - Include audio_path in callback_result dict for completeness Update README and CLAUDE.md with accurate counts: - 4,100+ tests (was 1,850+), 420+ modules, 17 DB migrations - 8 sidebar nav sections + 6 editor tabs + 6 analysis sub-tabs - ProcessingQueue 7 mixins, 80+ dialogs, 15 managers, 46 RAG modules - Added controllers, handlers, service registry to architecture docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_current_recording_id(private) vscurrent_recording_id(public) attribute mismatch — queue completion only set the private one, so downstream generators created new rows instead of updatingaudio_pathwas missing from the result dict, overwriting valid paths with''_on_queue_completion(data already saved bytask_executor_mixin)Test plan
🤖 Generated with Claude Code