fix: implement single-flight connection handling and add tests for Wa…#7205
Closed
fairlighteth wants to merge 5 commits intodevelopfrom
Closed
fix: implement single-flight connection handling and add tests for Wa…#7205fairlighteth wants to merge 5 commits intodevelopfrom
fairlighteth wants to merge 5 commits intodevelopfrom
Conversation
…lletConnectV2Connector
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…p on deactivation
…er initialization
…t and utility functions
…ove fallback logic
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce
MaxListenersExceededWarning/register_error listeners addednoise from the WalletConnect v2 path by fixing the app-side triggers instead of raising the listener limit.This change covers the full repro we investigated:
activate()calls while no session existsconnectEagerly()callsdeactivate()BlockNumberProviderfrom polling/subscribing through the wallet transport and use the chain RPC provider insteadTo Test
cowswap-frontendlocally and connect with a WalletConnect-compatible walletMaxListenersExceededWarning: Possible EventEmitter memory leak detected. ... register_error listeners addedTry Again, then connect successfullyBackground
The warning was not coming from CoW-owned frontend event emitters. The
register_errorlistener is added inside WalletConnect's JSON-RPC WebSocket/provider stack.The issue turned out to have multiple app-side triggers:
This patch fixes those triggers directly rather than increasing the listener limit, which would only hide the underlying problem.