-
Notifications
You must be signed in to change notification settings - Fork 30
docs: add quote-to-order tutorial with slippage guidance #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
data-cowwboy
wants to merge
11
commits into
main
Choose a base branch
from
docs/quote-to-order-tutorial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a1568eb
docs: add quote-to-order tutorial with slippage guidance
data-cowwboy 3552895
fixes
harisang 62eb315
Remove space
harisang 28408c5
more fixes
harisang 2a0a984
more fixes
harisang 40e1ff4
small fixes
harisang a5f5551
more fixes
harisang 437cf4c
rephrasings
harisang 1d339d2
fix typo
harisang 6fa8ff3
add zero fee
harisang 58fd8c0
docs: address PR review feedback for quote-to-order tutorial
data-cowwboy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cowprotocol/docs
Length of output: 1243
🏁 Script executed:
rg -i "feeAmount|fee.*amount" docs/ -A 2 -B 2 --max-count=20Repository: cowprotocol/docs
Length of output: 27326
🏁 Script executed:
rg "sellAmount.*feeAmount|feeAmount.*sellAmount" docs/ -B 3 -A 3 --max-count=10Repository: cowprotocol/docs
Length of output: 644
Fix syntax error on line 61 and correct feeAmount handling.
The code on line 61 has a syntax error (
const signature = signature: await signOrder(...)) with a duplicate assignment operator. Additionally, line 52 incorrectly addsfeeAmounttosellAmount;feeAmountshould remain as a separate field in the order object, as defined in the CoW Protocol order schema. Remove the feeAmount addition and pass it as a distinct field:Corrected code
🤖 Prompt for AI Agents