Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates Cozystack components from version 1.2.0 to 1.2.1 across various configuration files. The review feedback identifies several instances where version tags were incremented without updating the corresponding image digests, which likely indicates an oversight in the release process. Additionally, the reviewer cautioned against updating digests for existing version tags to maintain immutability, suggesting that a new version tag should be issued instead.
packages/core/platform/values.yaml
Outdated
| migrations: | ||
| enabled: false | ||
| image: ghcr.io/cozystack/cozystack/platform-migrations:v1.2.0@sha256:3a3d8cfa4323d8023b7c7800d8b552b250bc2de01ca7550fd024a10b12324f6d | ||
| image: ghcr.io/cozystack/cozystack/platform-migrations:v1.2.1@sha256:3a3d8cfa4323d8023b7c7800d8b552b250bc2de01ca7550fd024a10b12324f6d |
There was a problem hiding this comment.
The image digest for platform-migrations remains identical to the one used in v1.2.0 (sha256:3a3d8cfa...). Since this is a release PR where most other components have received new digests, this indicates that the image content has not been updated for the v1.2.1 release, which is likely unintentional.
| @@ -1,2 +1,2 @@ | |||
| e2e: | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.2.0@sha256:7964a3e4b11053887be201d62f94138c3a7836c861036c26fb833aa1fcb934e1 | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.2.1@sha256:7964a3e4b11053887be201d62f94138c3a7836c861036c26fb833aa1fcb934e1 | |||
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.2.0@sha256:b508ca451c6051b64e71cedd6209c80ac0e0bea8aa6bb47e838ec9d99bf4796a | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.2.1@sha256:b508ca451c6051b64e71cedd6209c80ac0e0bea8aa6bb47e838ec9d99bf4796a | |||
| image: ghcr.io/cozystack/cozystack/openapi-ui-k8s-bff:v1.2.1@sha256:f7e6723bde49e07160457ba92fb47d84e23f10e9ba7092f14a853c3d349dc287 | ||
| tokenProxy: | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v1.2.0@sha256:2e280991e07853ea48f97b0a42946afffa10d03d6a83d41099ed83e6ffc94fdc | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v1.2.1@sha256:2e280991e07853ea48f97b0a42946afffa10d03d6a83d41099ed83e6ffc94fdc |
There was a problem hiding this comment.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.2.0@sha256:2c9aa0b48e2bf6167db198f4d15882bfe51700108edf2e9f6d0942940a2c1204 | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.2.1@sha256:2c9aa0b48e2bf6167db198f4d15882bfe51700108edf2e9f6d0942940a2c1204 | |||
| objectstorage: | ||
| controller: | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-controller:v1.2.0@sha256:05aee8bf8b292150090868163c6bb49962d874ac63858c93f8e130f53dd40b85" | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-controller:v1.2.1@sha256:05aee8bf8b292150090868163c6bb49962d874ac63858c93f8e130f53dd40b85" |
| region: "" | ||
| sidecar: | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.2.0@sha256:b508ca451c6051b64e71cedd6209c80ac0e0bea8aa6bb47e838ec9d99bf4796a" | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.2.1@sha256:b508ca451c6051b64e71cedd6209c80ac0e0bea8aa6bb47e838ec9d99bf4796a" |
| image: | ||
| repository: ghcr.io/cozystack/cozystack/piraeus-server | ||
| tag: 1.32.3@sha256:64c91357affc6317d9544fc35b3ff8b2fcb065ad8fc5ed26f7a2fa8ac991a1c1 | ||
| tag: 1.32.3@sha256:d78071fdc33220168e3f2ab112a86208be95898b75268a0c62763b8a04e145ad |
There was a problem hiding this comment.
Signed-off-by: cozystack-bot <217169706+cozystack-bot@users.noreply.github.com>
ac51469 to
27638a1
Compare
This PR prepares the release
v1.2.1.