fix: extract _expat_options to remove duplication#293
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
…arse_start() Both methods had an identical loop filtering $self keys through Non_Expat_Options. Extract to a shared private method. Fixes #279 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 76.40% 76.54% +0.14%
==========================================
Files 1 1
Lines 1102 1113 +11
Branches 346 351 +5
==========================================
+ Hits 842 852 +10
Misses 52 52
- Partials 208 209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
parse()andparse_start()contained an identical 3-line loop filtering$selfkeys throughNon_Expat_Optionsto build@expat_options. Extracted to a shared private method_expat_options.Fixes #279
Changes
_expat_options()method that returns filtered key-value pairs usingmap/grepparse()andparse_start()with calls to_expat_options()t/expat_options_method.twith 4 tests covering filtering behavior and both call sitesTest plan
make testpasses all 731 tests across 64 filesNon_Expat_OptionsandHandlersare excluded from returned optionsparse()andparse_start()produce working parsers through the shared methodGenerated by Kōan /fix
Quality Report
Changes: 3 files changed, 291 insertions(+), 78 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline