fix: block XXE file disclosure in default external entity handler#294
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: block XXE file disclosure in default external entity handler#294toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
…ernEnt handler The default file_ext_ent_handler opens any file path from an XML external entity SYSTEM identifier, enabling XXE file disclosure attacks (e.g. /etc/passwd, ../../etc/shadow). Add path validation that rejects absolute paths and .. traversal components before file resolution. New UnsafeExternalEntities => 1 option restores the old behavior for applications that legitimately need unrestricted entity paths. Fixes #278 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 76.40% 76.54% +0.14%
==========================================
Files 1 1
Lines 1102 1113 +11
Branches 346 351 +5
==========================================
+ Hits 842 852 +10
Misses 52 52
- Partials 208 209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default
file_ext_ent_handlerallows arbitrary local file reads via XXE attacks — absolute paths (/etc/passwd) and directory traversal (../../etc/shadow) in external entity SYSTEM identifiers are passed directly toIO::File->new. This adds path validation that rejects absolute paths and..components before file resolution.A new
UnsafeExternalEntities => 1constructor option restores the old behavior for applications that legitimately need unrestricted entity paths.Fixes #278
Changes
..traversal infile_ext_ent_handler(before base-path resolution)UnsafeExternalEntitiesoption toNon_Expat_Options, propagated to Expat objectt/nolwp.tto useUnsafeExternalEntities => 1(uses absolute tempfile paths)t/xxe_path_restriction.twith 14 tests covering blocked paths, allowed paths, and opt-outTest plan
make testpasses all 741 tests across 64 files..traversal are blockedUnsafeExternalEntities => 1allows absolute paths end-to-endt/nolwp.t,t/external_ent.t,t/ext_ent_io_control.tcontinue passingGenerated by Kōan /fix
Quality Report
Changes: 5 files changed, 183 insertions(+), 4 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline