Feature/docker image management#20
Open
bradjin8 wants to merge 3 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue 4
Summary
Implement the Docker Image Management layer for the local CI system: load pre-built images from
.tarfiles, create new images when the registry has no matching image, save newly built images for reuse, enforce the image naming convention, and manage disk space by cleaning up old/unused images. This is the integration point between the Image Registry (Issue 3) and the Job Executor (Issue 5).Goal
.tarfiles so jobs can run without pulling from a remote registry..tarand register them for future runs.Context
best_image_pathorbest_base_image_pathandneeds_buildfrom the execution plan.actwith the prepared image.Deliverables
Load images from
.tarimages/<project>/<name>.tar), rundocker load -i <path>.docker images) and return the image reference (name:tag) foract(-P <runner>=<image>).Create new images when no match found
needs_build = truewithbest_base_image_path:.tar..tar; update registry (or call registry API from Issue 3).Save newly built images for reuse
docker save -o <path> <image>:<tag>.images/<project>/<name>.tar(see Design Guide).image-registry.ymlor equivalent) so the matching algorithm can select this image on future runs.Image naming convention enforcement
<project>-<os>-<variant>.tar(e.g.capy-ubuntu-25.04-gcc15.tar,capy-ubuntu-25.04-clang20-asan.tar).Disk space management (cleanup old images)
.tarfiles and optionallydocker rmifor loaded copies) and optionally alocalci images prune(or similar) command.disk_min_free_gb-style limits from config if present (see Design Guide).Acceptance Criteria
.tarpath can be loaded and used for a job; errors for missing/corrupt files are explicit.images/<project>/<name>.tarand appear in the registry.References
docker load/docker saveexamples.Branch:
feature/docker-image-management