don't include drafts and revisions in the deletion blocker reference count#609
Draft
i-just wants to merge 2 commits into
Draft
don't include drafts and revisions in the deletion blocker reference count#609i-just wants to merge 2 commits into
i-just wants to merge 2 commits into
Conversation
Contributor
Author
|
@brandonkelly, I’m assuming it’s intentional that we store the references for element drafts and revisions? (If not, further work will be needed here.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Element revisions were counted towards existing references for deletion blockers.
With “native” references (e.g. an entry that’s selected as part of the Link or Entries field), the drafts and revisions are not counted towards references shown by the deletion blocker.
Fix: don’t include drafts and revisions in the reference count.
Related issues
#600