[5.x] Admin table action buttons firing on render#19259
Open
nfourtythree wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in the Vue admin table action button component where an AJAX action could be executed during re-render (e.g., when selecting rows) because the click handler was invoked while binding the listener.
Changes:
- Wrap the AJAX click handler in a function so it runs on user click rather than during render.
- Adjust the button
typebinding to ensure non-menu buttons have an explicittype(submitfor non-AJAX when enabled; otherwisebutton). - Add a Craft 5 changelog entry under “Unreleased” referencing the fix and linked issue.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/craftcms-vue/admintable/components/AdminTableActionButton.vue | Fixes the event binding so AJAX actions don’t fire during render; tweaks button type behavior. |
| CHANGELOG.md | Documents the bugfix under the new “Unreleased” section with an issue link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| enabled && !isMenuButton && ajax | ||
| ? {click: handleClick(param, value, action, ajax, handleClick)} | ||
| ? { | ||
| click: () => handleClick(param, value, action, ajax, handleClick), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix accidentally firing action buttons on admin tables
Related issues
#19255