[5.x] Prevent incompatible bulk entry moves#19268
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents bulk entry section moves from completing when one or more selected entries have an entry type that isn’t supported by the destination section, avoiding persisted “incompatible” entry type/section combinations.
Changes:
- Tighten the “Move to section” modal section-compatibility filter to require all selected entry types be supported by the target section.
- Add a preflight validation in the bulk move action to reject the request if any selected entry type isn’t supported by the destination section.
- Add a defensive validation in the Entries service to block single moves when the entry’s type isn’t supported by the target section.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/services/Entries.php | Adds a service-level guard preventing moves to sections that don’t support the entry’s type. |
| src/controllers/EntriesController.php | Ensures the modal and bulk move endpoint only allow moves when all selected entry types are supported by the destination section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
riasvdv
marked this pull request as ready for review
July 20, 2026 08:00
i-just
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent bulk entry moves from persisting entry types that are unsupported by the destination section.