-
Notifications
You must be signed in to change notification settings - Fork 4
Send numeric service code in product.id for Booking API #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−3
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several common products and their return variants appear to be missing from the numeric mapping. Specifically,
HOME_DELIVERY_PARCEL(5600),BUSINESS_PALLET(5200), andRETURN_HOME_DELIVERY_PARCEL(9600) are standard Bring products. Without these mappings, booking requests for these products will fall back to their string enum values, which will trigger the sameBOOK-INPUT-025/BOOK_VALIDATION-014validation errors for domestic Norway shipments.Adding these mappings ensures complete coverage for all standard products supported by the Booking API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off on these specific mappings. Cross-referencing against the v3 SDK's
Crakter\BringApi\DefaultData\Productscatalog (which is the source for the codes I did add), I can't confirm any of the three:RETUREKSPRESS(return-express, i.e. the return variant of EXPRESS_NORDIC_0900) — notRETURN_HOME_DELIVERY_PARCEL. Mapping it as the home-delivery return would silently book the wrong product.5600candidate as a "DISTRIBUTION" code — different again.)A wrong numeric code silently books the wrong product; the current string fallback at worst surfaces a 4xx, which is the safer failure mode. Documented the gap on the method so the next person hitting BOOK-INPUT-025 on an unmapped product knows to look up the code in Mybring rather than guess — see c2dc9bf.
If you have authoritative codes for these from Bring's product catalog, happy to add them.
Generated by Claude Code