fix(shipping-guide): map express to 4850, not 0335#65
Merged
Conversation
Correcting a wrong code from the previous commit. The EXPRESS_NORDIC_0900
case is this catalog's everyday express parcel = Business Parcel Express
("Pakke til bedrift ekspress"), whose Shipping Guide service code is 4850
— confirmed against Bring's revised-services list (5000/5100/5300/5600/
5800/4850) and matching the in-app calculator's own code.
0335 is a different, soon-decommissioned product ("Express Nordic 09:00"
courier); sending it returned no price for accounts without that service.
shippingGuideCode() now matches legacyNumericCode() for express (4850).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the EXPRESS_NORDIC_0900 product mapping in Product::shippingGuideCode() to map to '4850' (Business Parcel Express) instead of '0335' (Express Nordic 09:00), which is being decommissioned. The changelog, documentation, and corresponding unit tests have been updated to reflect this change. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction
Follow-up to #64. That PR shipped the wrong numeric code for express:
Product::shippingGuideCode()mappedEXPRESS_NORDIC_0900→0335. On master this means express price lookups now send0335— a different product ("Express Nordic 09:00" courier, decommissioned 2026-09-01) that isn't available on the account, so express still returns no price.The correct Shipping Guide code is
4850= Business Parcel Express ("Pakke til bedrift ekspress") — confirmed against Bring's revised-services list (5000 / 5100 / 5300 / 5600 / 5800 / 4850), and matching both the in-app calculator's own code andlegacyNumericCode().Change
shippingGuideCode():EXPRESS_NORDIC_0900→'4850'(was'0335').PriceRequestTestto assert['4850'].Express codes now round-trip cleanly:
4850 → EXPRESS_NORDIC_0900 → 4850.Verification
PriceRequestTest, full suite greenNote
The
?? $p->valuefallback for products without a confirmed numeric code still emits the literal v2 string name. It never triggers for the calculator's products (4850/5800/5000, all mapped), but is a latent issue for unmapped products if Bring has deprecated the string names wholesale — left as-is pending confirmation of which string names still price.https://claude.ai/code/session_01TLPjgivGN5mopPrs4vcfBp
Generated by Claude Code