Client-side Support#39
Open
wintondeshong wants to merge 1 commit into
Open
Conversation
…with equivilent underscore.js functions; Refactored String.trim to use internal trim function; Refactored primary Haml signature to exclude 'Haml' from '...function Haml(haml, config) {'
|
+1 |
1 similar comment
|
+1 |
Author
|
Note: You must add json2.js as a dependency when using this on the client-side (https://github.com/douglascrockford/JSON-js) as IE7 and lower don't natively support JSON.stringify. |
|
+1 🍺 |
|
This is great. +1 |
|
+1 |
5 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
Anything happening here? |
|
+1 Looks like their have been a few updates to master since winton's changes. |
|
In the meantime, I've pulled the upstream changes into this fork on winton's branch: https://github.com/rmw/haml-js/blob/master/lib/haml.js In case anyone wants it ... |
|
+1 |
1 similar comment
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my fork of haml-js to allow for client-side support (primarily internet explorer)
Outline of changes:
Refactored Array.forEach, Array.indexOf, Array.map, and Array.filter with equivilent underscore.js functions
Refactored String.trim to use internal trim function
Refactored primary Haml signature to exclude 'Haml' from '...function Haml(haml, config) {'