Reword wallet chooser permission dialog copy#185
Conversation
Replace the abstract 'wants to manage credentials for you' with concrete language describing what the user will experience later: 'wants to appear as an option when you're asked to share or store information on other websites'. Most users don't have a mental model for 'credentials' as a category; this describes the future action instead of the abstract permission grant. Addresses #150.
|
We need some screenshots of this on different browsers to see how it looks -- and it might require popup size adjustments too. |
|
@dlongley here are screenshots Desktop popupsChromium
Firefox
WebKit / Safari
MobileiPhone
Android / Pixel
|
|
Heh, well, those look terrible :P. We'll need to do something about all that empty space. |
|
The empty space isn't from the reworded copy — it's the modal's built-in mobile behavior in In upstream @media only screen and (max-width: @wrm-modal-small-screen) { // 400px + 30px padding = 430px
&:not(.wrm-modal-1p) {
height: 100%;
justify-content: flex-end;
}
}So on any narrow viewport the modal is forced to This is independent of the text — the previous copy wasn't long either, so it would have shown the same gap on mobile. The reword just drew the eye to it. Before I fix it: on mobile, do you want the permission dialog to (a) shrink to a compact card like it does on desktop, or (b) stay a full-screen sheet with the buttons anchored at the bottom, just without the awkward gap? I'd lean toward (a) since there's no scrollable list here, but it's your call on the intended mobile look. |
|
Ok, I understand that those screenshots were for mobile now. Let's leave that be in this PR -- we can consider ways to improve the appearance on mobile later. What do the desktop screenshots look like? Do they overflow/crowd out the buttons or anything, or do they also look ok? |
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
The lockfile version fields lagged at 7.5.2 while package.json was already at 7.5.1, matching main. Restore the lockfile so this PR introduces no package version change; the release tooling bumps the version from the CHANGELOG entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b9f4e6f to
64cfb3d
Compare










Summary
Test plan
npx eslint web/components/MediatorGreeting.vuepassespermissionRequestdialog state via the/test/wallet-chooser?type=permissionRequestdev harness on desktop (chromium) and mobile (iPhone) viewports — new copy wraps to 2-3 lines with no overflow or button crowdingnpm run gallery(wallet chooser hint-list states) still passesAddresses #150.