Skip to content

Reword wallet chooser permission dialog copy#185

Merged
dlongley merged 3 commits into
mainfrom
fix-wallet-permission-copy
Jul 23, 2026
Merged

Reword wallet chooser permission dialog copy#185
dlongley merged 3 commits into
mainfrom
fix-wallet-permission-copy

Conversation

@djscruggs

Copy link
Copy Markdown
Contributor

Summary

  • Replace the abstract "wants to manage credentials for you" permission-dialog copy with concrete, jargon-free language: "wants to appear as an option when you're asked to share or store information on other websites."
  • Bump version to 7.5.2 and add a CHANGELOG entry.

Test plan

  • npx eslint web/components/MediatorGreeting.vue passes
  • Rendered the permissionRequest dialog state via the /test/wallet-chooser?type=permissionRequest dev harness on desktop (chromium) and mobile (iPhone) viewports — new copy wraps to 2-3 lines with no overflow or button crowding
  • npm run gallery (wallet chooser hint-list states) still passes

Addresses #150.

Replace the abstract 'wants to manage credentials for you' with
concrete language describing what the user will experience later:
'wants to appear as an option when you're asked to share or store
information on other websites'. Most users don't have a mental model
for 'credentials' as a category; this describes the future action
instead of the abstract permission grant.

Addresses #150.
@djscruggs
djscruggs requested a review from dlongley July 20, 2026 20:54
@dlongley

Copy link
Copy Markdown
Contributor

We need some screenshots of this on different browsers to see how it looks -- and it might require popup size adjustments too.

@dlongley
dlongley requested a review from jameseaster July 20, 2026 23:30
@djscruggs

djscruggs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@dlongley here are screenshots

Desktop popups

Chromium

popup-chromium-light popup-chromium-dark

Firefox

popup-firefox-light popup-firefox-dark

WebKit / Safari

popup-webkit-light popup-webkit-dark

Mobile

iPhone

permission-iphone-light permission-iphone-dark

Android / Pixel

permission-android-pixel-light permission-android-pixel-dark

@dlongley

Copy link
Copy Markdown
Contributor

Heh, well, those look terrible :P. We'll need to do something about all that empty space.

@djscruggs

Copy link
Copy Markdown
Contributor Author

The empty space isn't from the reworded copy — it's the modal's built-in mobile behavior in vue-web-request-mediator.

In upstream style/main.less, any .wrm-modal that isn't the 1p wallet-chooser goes full-screen below the small-screen breakpoint (~430px wide):

@media only screen and (max-width: @wrm-modal-small-screen) { // 400px + 30px padding = 430px
  &:not(.wrm-modal-1p) {
    height: 100%;
    justify-content: flex-end;
  }
}

So on any narrow viewport the modal is forced to height: 100% with content pinned to the bottom (justify-content: flex-end). The permission dialog has very little content, so "fill the screen" leaves a big gap between the origin card and the Block/Allow buttons. The desktop shots (chromium/firefox at 500px wide) clear the breakpoint, stay content-sized, and look fine.

This is independent of the text — the previous copy wasn't long either, so it would have shown the same gap on mobile. The reword just drew the eye to it.

Before I fix it: on mobile, do you want the permission dialog to (a) shrink to a compact card like it does on desktop, or (b) stay a full-screen sheet with the buttons anchored at the bottom, just without the awkward gap? I'd lean toward (a) since there's no scrollable list here, but it's your call on the intended mobile look.

@dlongley

Copy link
Copy Markdown
Contributor

Ok, I understand that those screenshots were for mobile now. Let's leave that be in this PR -- we can consider ways to improve the appearance on mobile later.

What do the desktop screenshots look like? Do they overflow/crowd out the buttons or anything, or do they also look ok?

Comment thread package.json Outdated
Comment thread CHANGELOG.md Outdated
dlongley and others added 2 commits July 22, 2026 15:18
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
The lockfile version fields lagged at 7.5.2 while package.json was
already at 7.5.1, matching main. Restore the lockfile so this PR
introduces no package version change; the release tooling bumps the
version from the CHANGELOG entry.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@djscruggs
djscruggs force-pushed the fix-wallet-permission-copy branch from b9f4e6f to 64cfb3d Compare July 23, 2026 22:01
@dlongley
dlongley merged commit 9f60738 into main Jul 23, 2026
1 check passed
@dlongley
dlongley deleted the fix-wallet-permission-copy branch July 23, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants