function: Add missing dependencies to the Go function template#109
Merged
Conversation
The go.mod and go.sum in the Go function template were missing two transitive dependencies, requiring the user to run `go mod tidy` before any function that uses our generated schemas would build correctly: - `github.com/oapi-codegen/runtime v1.1.0 // indirect` - `github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect` Add these two dependencies and their corresponding go.sum entries to the template in go.tar. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
haarchri
approved these changes
Jun 15, 2026
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The go.mod and go.sum in the Go function template were missing two transitive dependencies, requiring the user to run
go mod tidybefore any function that uses our generated schemas would build correctly:github.com/oapi-codegen/runtime v1.1.0 // indirectgithub.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirectAdd these two dependencies and their corresponding go.sum entries to the template in go.tar.
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.