Skip to content

function: Add missing dependencies to the Go function template#109

Merged
adamwg merged 1 commit into
crossplane:mainfrom
adamwg:awg/go-sum-missing
Jun 15, 2026
Merged

function: Add missing dependencies to the Go function template#109
adamwg merged 1 commit into
crossplane:mainfrom
adamwg:awg/go-sum-missing

Conversation

@adamwg

@adamwg adamwg commented Jun 15, 2026

Copy link
Copy Markdown
Member

Description of your changes

The go.mod and go.sum in the Go function template were missing two transitive dependencies, requiring the user to run go mod tidy before any function that uses our generated schemas would build correctly:

  • github.com/oapi-codegen/runtime v1.1.0 // indirect
  • github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect

Add these two dependencies and their corresponding go.sum entries to the template in go.tar.

I have:

The go.mod and go.sum in the Go function template were missing two transitive
dependencies, requiring the user to run `go mod tidy` before any function that
uses our generated schemas would build correctly:

- `github.com/oapi-codegen/runtime v1.1.0 // indirect`
- `github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect`

Add these two dependencies and their corresponding go.sum entries to the
template in go.tar.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@adamwg adamwg requested review from a team, jcogilvie and tampakrap as code owners June 15, 2026 17:39
@adamwg adamwg requested review from phisco and removed request for a team June 15, 2026 17:39
@adamwg adamwg merged commit a03dc65 into crossplane:main Jun 15, 2026
10 checks passed
@adamwg adamwg deleted the awg/go-sum-missing branch June 15, 2026 18:58
@github-actions

Copy link
Copy Markdown

Successfully created backport PR for release-2.3:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants