feat: add Description field to SSA InjectedKey#672
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a ChangesConfigurable injected key description
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/config/resource.go`:
- Around line 384-388: The InjectedKey struct's Description field lacks GoDoc;
add a GoDoc comment above Description in the InjectedKey type (reference:
InjectedKey.Description) explaining that it is the OpenAPI schema description
for the injected list-map key field, that providers may supply a custom
description, and that when empty it defaults to a standard description about
server-side apply/merge behavior so consumers understand its purpose and default
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e431b676-2494-4051-9964-162576365f5e
📒 Files selected for processing (3)
pkg/config/resource.gopkg/types/builder.gopkg/types/builder_test.go
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
Description of your changes
Add a customizable
Descriptionfield toInjectedKeystruct. Before, SSA injected keys always got hardcoded description.Now providers can set their own (for instance, omit the "this is an injected field with a default value..." sentence, which might be misleading) when there isn't a default value set.
Fixes #671
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Add unit test.