Repository navigation
Conversation
added 3 commits
October 24, 2026 19:08
The duplicate check kept only a-z and 0-9, so two different Japanese titles that share a number (e.g. two Kumon workbooks for 1st grade) both became "1" and were offered for merging.
Dropping marks made Thai titles that differ only in a tone mark look the same: ป่า (forest) and ป้า (aunt) both became "ป า". Hindi and Arabic vowel signs had the same problem.
Editions in two languages can share a title, like "1984" in English and in German. When both books have a language and the main subtags differ, they aren't offered for merging. A missing language still matches, and "en" matches "en-GB".
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicate notice compares title and author. I have books whose title doesn't change between languages: "1984" in English and in German, or a German edition of a book I first read in English with the same title. Those got offered for merging.
Now, when both books have a language and they differ, they don't count as duplicates. Only the main subtag is compared, so "en" and "en-GB" still match. If either book has no language, it works like before.
Two tests added next to the ones from #38: different languages are kept apart, and a regional variant still counts as the same language. The full Library test file passes (8 tests) on Node 24.