Skip to content

fix: allow trailing slash in the base_url #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katerina20 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: allow trailing slash in the base_url #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ff24b
fix: allow trailing slash in the base_url
katerina20 May 3, 2026
9efad19
remove repeatable null check
katerina20 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions file-zero.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@andrii-bodnar andrii-bodnar May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ен": "тато"
}
3 changes: 2 additions & 1 deletion src/main/java/com/crowdin/cli/commands/functionality/PropertiesBeanUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private static boolean isUrlOfficial(String baseUrl) {
}

public static boolean isUrlValid(String baseUrl) {
return isUrlForTesting(baseUrl) || isUrlOfficial(baseUrl);
String normalized = StringUtils.removeEnd(baseUrl, "/");
return isUrlForTesting(normalized) || isUrlOfficial(normalized);
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/test/java/com/crowdin/cli/commands/functionality/PropertiesBeanUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,11 @@ private static Stream<Arguments> testIsUrlValid() {
arguments("https://organizzzation.daanya.crowdin.dev"),
arguments("https://daanya.crowdin.dev"),
arguments("https://98011165-2619304c.test.crowdin.com"),
arguments("https://myorg.e-test.crowdin.com")
arguments("https://myorg.e-test.crowdin.com"),
arguments("https://Daanya.crowdin.com/"),
arguments("https://Daanya.api.crowdin.com/"),
arguments("https://organizzzation.daanya.crowdin.dev/"),
arguments("https://myorg.e-test.crowdin.com/")
);
}

Expand Down
Loading