Skip to content

Typescript types#113

Merged
crubier merged 5 commits into
crubier:masterfrom
notourist:typescript-types
Apr 9, 2022
Merged

Typescript types#113
crubier merged 5 commits into
crubier:masterfrom
notourist:typescript-types

Conversation

@notourist

@notourist notourist commented Apr 27, 2021

Copy link
Copy Markdown

I added and polished the types from @ChadJPetersen (https://gist.github.com/ChadJPetersen/2e2587bbd753c6a384c02519183e2031). If you don't want to merge #112, 5bc7e31 needs to be reverted.

This also fixes #80

@jsdtaylor

Copy link
Copy Markdown

@usr14 can you use params?: unknown instead of any?

@jbrownson

Copy link
Copy Markdown

I'm looking at using react-graph-vis in a Typescript project and it would be great to have types, is this just being held up by the change requested by @jsdtaylor?

@crubier crubier merged commit 463323a into crubier:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot use react-graph-vis with typescript

4 participants